-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.22.1 branch] Wasm Configuration for Ambient Mode - Updates #15172
[release-1.22.1 branch] Wasm Configuration for Ambient Mode - Updates #15172
Conversation
* updated docs and test * revert go.mod * revert changes in go.mod * fixed lint error * Update snips.sh * removed service specific waypoint creation step * removed service specific waypoint creation step
This needs to be merged only for 1.22.1 |
Assuming that the test failure is because we need to move the testing reference to 1.22.1 which will happen at release time (along with any doc reference updates). |
That is correct @ericvn |
/retest |
Closes #15166 |
Should this work now? @kfaseela |
If the test is running against 1.22.1 this should pass now. |
/retest |
@zirain @dhawton is it possible to confirm if the below PR made it to 1.22.1? Then only the current PR will pass the docs test. istio/istio#51063 |
/retest |
It is in 1.22.1... https://github.com/istio/istio/commits/release-1.22.1-patch/ lists the commit |
It doesn't seem like we have bumped what version we are installing in docs. https://github.com/istio/istio.io/blob/release-1.22/go.mod#L16 I can do this in the morning |
Thanks @dhawton. Can we add this step to what the RMs do when they cut a new point release? |
we need to retest after #15354 |
/retest |
1 similar comment
/retest |
Manual cherry pick of : #15136
Fixes #15166