Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.22.1 branch] Wasm Configuration for Ambient Mode - Updates #15172

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

adilmp1
Copy link
Member

@adilmp1 adilmp1 commented May 23, 2024

Manual cherry pick of : #15136

Fixes #15166

* updated docs and test

* revert go.mod

* revert changes in go.mod

* fixed lint error

* Update snips.sh

* removed service specific waypoint creation step

* removed service specific waypoint creation step
@adilmp1 adilmp1 requested a review from a team as a code owner May 23, 2024 08:34
@istio-testing istio-testing added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 23, 2024
@adilmp1 adilmp1 changed the title Wasm Configuration for Ambient Mode - Updates release-1.22 branch [release-1.22 branch] Wasm Configuration for Ambient Mode - Updates May 23, 2024
@adilmp1 adilmp1 changed the title [release-1.22 branch] Wasm Configuration for Ambient Mode - Updates [release-1.22.1 branch] Wasm Configuration for Ambient Mode - Updates May 23, 2024
@kfaseela
Copy link
Member

kfaseela commented May 23, 2024

This needs to be merged only for 1.22.1

@ericvn
Copy link
Contributor

ericvn commented May 28, 2024

Assuming that the test failure is because we need to move the testing reference to 1.22.1 which will happen at release time (along with any doc reference updates).

@kfaseela
Copy link
Member

That is correct @ericvn

@craigbox
Copy link
Contributor

craigbox commented Jun 26, 2024

/retest

@craigbox
Copy link
Contributor

Closes #15166

@kfaseela
Copy link
Member

If the test is running against 1.22.1 this should pass now.

@dhawton
Copy link
Member

dhawton commented Jun 26, 2024

/retest

@kfaseela
Copy link
Member

@zirain @dhawton is it possible to confirm if the below PR made it to 1.22.1? Then only the current PR will pass the docs test. istio/istio#51063

@kfaseela
Copy link
Member

/retest

@dhawton
Copy link
Member

dhawton commented Jun 27, 2024

It is in 1.22.1... https://github.com/istio/istio/commits/release-1.22.1-patch/ lists the commit

@dhawton
Copy link
Member

dhawton commented Jun 27, 2024

It doesn't seem like we have bumped what version we are installing in docs. https://github.com/istio/istio.io/blob/release-1.22/go.mod#L16 I can do this in the morning

@craigbox
Copy link
Contributor

Thanks @dhawton. Can we add this step to what the RMs do when they cut a new point release?

@kfaseela
Copy link
Member

we need to retest after #15354

@kfaseela
Copy link
Member

/retest

1 similar comment
@kfaseela
Copy link
Member

/retest

@istio-testing istio-testing merged commit 57ad27f into istio:release-1.22 Jun 27, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants